Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #7042 Argument 2 ($url) passed to exclude_rocket_from_wp_updates() must be of the type string #7059

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

Fixes #7042 Argument 2 ($url) passed to exclude_rocket_from_wp_updates() must be of the type string #7059

wants to merge 3 commits into from
+5 −1

Conversation

Khadreal
Copy link
Contributor

Description

Fixes #7042
Fixed error for some users when updating from one version to another.

Type of change

  • Bug fix (non-breaking change which fixes an issue).

Detailed scenario

Check #7042

Technical description

Revert the phpstan update on the method.

Documentation

Mandatory Checklist

Code validation

  • I validated all the Acceptance Criteria. If possible, provide screenshots or videos.
  • I triggered all changed lines of code at least once without new errors/warnings/notices.

Code style

  • I wrote a self-explanatory code about what it does.
  • I protected entry points against unexpected inputs.
  • I did not introduce unnecessary complexity.

@Khadreal Khadreal self-assigned this Oct 25, 2024
@Khadreal Khadreal requested a review from a team October 25, 2024 09:57
@Khadreal Khadreal added the type: bug Indicates an unexpected problem or unintended behavior label Oct 25, 2024
@codacy-production Codacy Production
Copy link

codacy-production bot commented Oct 25, 2024 •
edited
Loading

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
Report missing for 8c1fed91 ✅ 50.00% (target: 50.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (8c1fed9) Report Missing Report Missing Report Missing
Head commit (92464d1) 37758 16604 43.97%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#7059) 2 1 50.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Footnotes

  1. Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct. ↩

Miraeld
Miraeld requested changes Oct 25, 2024
View reviewed changes
inc/Engine/Plugin/UpdaterSubscriber.php Outdated Show resolved Hide resolved
@Miraeld Miraeld self-requested a review October 25, 2024 12:17
@Khadreal Khadreal changed the title Fixes #7042 Fixes #7042 Argument 2 ($url) passed to exclude_rocket_from_wp_updates() must be of the type string Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Miraeld Miraeld Miraeld approved these changes

Assignees

@Khadreal Khadreal

Labels
type: bug Indicates an unexpected problem or unintended behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Argument 2 ($url) passed to exclude_rocket_from_wp_updates() must be of the type string
2 participants
@Khadreal @Miraeld